Fix git-lfs check to display error message#228
Open
kalakris wants to merge 1 commit intoNVIDIA-ISAAC-ROS:release-3.2from
Open
Fix git-lfs check to display error message#228kalakris wants to merge 1 commit intoNVIDIA-ISAAC-ROS:release-3.2from
kalakris wants to merge 1 commit intoNVIDIA-ISAAC-ROS:release-3.2from
Conversation
The previous code used `git lfs &>/dev/null` followed by checking `$?`, but since the script uses `set -e`, the script would exit immediately on the non-zero return code before reaching the error message. This also fixes the typo "insalled" -> "installed". Fixes NVIDIA-ISAAC-ROS#151, NVIDIA-ISAAC-ROS#167, NVIDIA-ISAAC-ROS#176 Generated with [Claude Code](https://claude.ai/code) via [Happy](https://happy.engineering) Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: Happy <yesreply@happy.engineering>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure if you accept patches on releases, but I don't think this applies to the latest version.
Summary
git lfs &>/dev/nullfollowed by checking$?, but since the script usesset -e, the script exits immediately on the non-zero return code before reaching theprint_errorcallRoot Cause
Fix
Fixes #151, #167, #176