Fix(run_dev.sh): Gracefully handle uninstalled 'git-lfs' under 'set -e'#217
Open
liangchengpei wants to merge 1 commit intoNVIDIA-ISAAC-ROS:mainfrom
Open
Fix(run_dev.sh): Gracefully handle uninstalled 'git-lfs' under 'set -e'#217liangchengpei wants to merge 1 commit intoNVIDIA-ISAAC-ROS:mainfrom
liangchengpei wants to merge 1 commit intoNVIDIA-ISAAC-ROS:mainfrom
Conversation
The script was prematurely exiting if the user did not have 'git-lfs' installed, due to a conflict with the global 'set -e' directive.
The original check was a bare command: `git lfs &>/dev/null`.
Since the script uses `set -e` (which causes the script to exit immediately if any command returns a non-zero status), if `git lfs` was not found (or failed), it would return a non-zero status. This caused the entire script to abort immediately without executing the intended error handling logic. This resulted in a silent or confusing failure for the user.
The check has been refactored into an explicit conditional block:
```bash
if ! git lfs &>/dev/null; then
print_error "git-lfs is not insalled. Please make sure git-lfs is installed before you clone the repo."
exit 1
fi
```
By wrapping the check in `if ! ...; then`, the exit status of `git lfs` is explicitly handled by the `if` statement. This prevents `set -e` from prematurely exiting the script and ensures that the script prints the intended, user-friendly error message before exiting with status 1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The script was prematurely exiting if the user did not have 'git-lfs' installed, due to a conflict with the global 'set -e' directive.
The original check was a bare command:
git lfs &>/dev/null. Since the script usesset -e(which causes the script to exit immediately if any command returns a non-zero status), ifgit lfswas not found (or failed), it would return a non-zero status. This caused the entire script to abort immediately without executing the intended error handling logic. This resulted in a silent or confusing failure for the user.The check has been refactored into an explicit conditional block:
By wrapping the check in
if ! ...; then, the exit status ofgit lfsis explicitly handled by theifstatement. This preventsset -efrom prematurely exiting the script and ensures that the script prints the intended, user-friendly error message before exiting with status 1.