run_dev.sh: Enable tests to fail gracefully#159
Open
bsb808 wants to merge 1 commit intoNVIDIA-ISAAC-ROS:release-3.1from
Open
run_dev.sh: Enable tests to fail gracefully#159bsb808 wants to merge 1 commit intoNVIDIA-ISAAC-ROS:release-3.1from
bsb808 wants to merge 1 commit intoNVIDIA-ISAAC-ROS:release-3.1from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
When following the issac_ros_nvblox quickstart tutorial the verification of host setup (e.g., checking to see if git-lfs is installed) fail silently. This is because of the
set -efail fast option which exits before the output to stdout.Fix
I added edits to two of the obvious checks that will fail silently enabling them to provide the desired reporting to stdout.