Request substitution confirmation pop-up #596
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tts-fe-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
This PR implements a request substitution confirmation flow that detects duplicate exchange requests and allows users to replace existing requests with new ones. When the backend returns a duplicate error, the form displays a warning message and changes the submit button to explicitly indicate that submitting will cancel the previous request.
Key Changes:
- Added duplicate request detection and handling with
hasDuplicatestate flag - Modified submission flow to include a
replaceparameter when resubmitting after duplicate detection - Updated UI to show appropriate warnings and button text when duplicates are detected
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| PreviewRequestForm.tsx | Added duplicate detection logic, state management for hasDuplicate, and conditional alert display for duplicate warnings |
| ExchangeSubmissionConfirmation.tsx | Updated submit button to show context-specific text and icon based on whether a duplicate exists, added hasDuplicate prop |
| exchangeRequestService.ts | Added replace parameter to submitExchangeRequest function and included it in FormData when true |
| .env.example | Removed placeholder character from APP_SENTRY_AUTH_TOKEN |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tomaspalma
reviewed
Dec 28, 2025
tomaspalma
reviewed
Dec 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #515. Modifies
PreviewRequestFormto, when receiving a duplicate request, allow the user to retry submitting the request by asking the server to replace the old one. The currently implemented flow is the following:replace: trueSee also this PR for the backend.
Important
When testing this branch, don't forget to also checkout the backend to the branch
feature/confirmation-popupRequest form when a duplicate is detected
Changes Made
PreviewRequestFormto show new view when receives aduplicate-requesterror from the serverreplace: true