Skip to content

Conversation

@michaelmackenzie
Copy link
Contributor

I found there were some cases where the prescale module was running slowly for some reason. I've updated to store the info from the input config tables in a simple struct, and only do the std::string comparison test at construction. I didn't observe any slow behavior after this update in 40k no primary events. I also updated to input an int instead a float prescale value, since it was being cast to an int in the end either way.

@FNALbuild
Copy link
Collaborator

Hi @michaelmackenzie,
You have proposed changes to files in these packages:

  • Trigger

which require these tests: build.

@Mu2e/fnalbuild-users, @Mu2e/write have access to CI actions on main.

⌛ The following tests have been triggered for b247198: build (Build queue - API unavailable)

About FNALbuild. Code review on Mu2e/Offline.

@FNALbuild
Copy link
Collaborator

☀️ The build tests passed at b247198.

Test Result Details
test with Command did not list any other PRs to include
merge Merged b247198 at e391635
build (prof) Log file. Build time: 04 min 47 sec
ceSimReco Log file.
g4test_03MT Log file.
transportOnly Log file.
POT Log file.
g4study Log file.
cosmicSimReco Log file.
cosmicOffSpill Log file.
ceSteps Log file.
ceDigi Log file.
muDauSteps Log file.
ceMix Log file.
rootOverlaps Log file.
g4surfaceCheck Log file.
trigger Log file.
check_cmake Log file.
FIXME, TODO TODO (0) FIXME (0) in 1 files
clang-tidy 🔶 2 errors 5 warnings
whitespace check no whitespace errors found

N.B. These results were obtained from a build of this Pull Request at b247198 after being merged into the base branch at e391635.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants