Add Orgon #1391
Open
Add Orgon #1391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| } | ||
| }, | ||
| "npm:orgon-snap": { |
Member
There was a problem hiding this comment.
This Snap exposes keyring methods over onRpcRequest, which is not intended. Additionally we may also be moving away from supporting invokeKeyring from dapps.
cc @danroc
Contributor
There was a problem hiding this comment.
I also noticed that they expose other methods with the keyring_ prefix that are not defined nor supported by us. Also, the methods that we do support, like keyring_createAccount, have different return types.
I think it's a mistake that this Snap is using the keyring endowment, they probably meant to use plain RPC methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #1384
Note
Adds
npm:orgon-snap(Orgon wallet snap) tosrc/registry.jsonwith version1.0.6.src/registry.json):npm:orgon-snap1.0.6with checksumWritten by Cursor Bugbot for commit 167d6ee. This will update automatically on new commits. Configure here.