Grammar checks #132
Open
Grammar checks #132
+1,278
−1,253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* MLAB-6146: checked and fixed grammar * MLAB-6146: fixes after review
- this had some unwanted side effects - adapt all URLs to work without the setting (remove /) - do not use absolute links to the site URL
|
A preview of is uploaded and can be seen here: ✨ https://mevislab.github.io/examples/pull/132/ ✨ Changes may take a few minutes to propagate. Since this is a preview of production, content with |
okonrad
requested review from
Meekalll,
mrbean-bremen and
sahehb
and removed request for
Meekalll
Contributor
mrbean-bremen
left a comment
mrbean-bremen
left a comment
There was a problem hiding this comment.
Thanks for doing this tedious work!
Comment on lines
+49
to
+50
| labelString = f'Length: {cso.getLength()} mm' | ||
| labelName = f'ID: {cso.getId()}' |
Contributor
There was a problem hiding this comment.
Black demands double quotation marks, so these should remain.
|  | ||
|
|
||
| For labels shown on grayscale images, it makes sense to add a shadow. Open the panel of the `SoCSOVisualizationSettings` module and on tab *Misc* check the option *Should render shadow*. This increases the readability of your labels. | ||
| For labels shown on gray value images, it makes sense to add a shadow. Open the panel of the `SoCSOVisualizationSettings` module and on tab *Misc* check the option *Should render shadow*. This increases the readability of your labels. |
Contributor
There was a problem hiding this comment.
"grayscales image" is a well-defined name, so I would leave it
|  | ||
|
|
||
| You can design the annotation overlay as you like in the tab *User*. We decided to only display the minimum and maximum distance between both WEMs. | ||
| You can design the annotation overlay as you like in the tab *User*. We decided to only display the minimal (the minimum minimum) and maximal (the maximum minimum) distance between both WEMs. |
Contributor
There was a problem hiding this comment.
I find that (minimum minimum / minimum maximum) a bit confusing
|
|
||
|  | ||
|  | ||
|
|
Contributor
There was a problem hiding this comment.
"multi-frame" is correct (at least in DICOM)
| ## Summary | ||
| * Multi-frame DICOM images can be rendered to be scene objects by converting them into WEMs first | ||
| * Open Inventor scenes can be augmented by adding PostEffects to scene objects | ||
| * Multiframe DICOM images can be rendered to be scene objects by converting them into WEMs first. |
| * Filename to be opened | ||
| * Color of the 2D overlay and 3D segmentation | ||
| * Transparency of the 3D image | ||
| * Threshold to be used for RegionGrowing |
Contributor
There was a problem hiding this comment.
region growing? or RegionGrowing, if the module is meant (same below)
| For a reset, we just touch the *resetApplication* field of our macro module `TutorialSummary`. | ||
|
|
||
| #### Requirement 1: The application shall be able to load DICOM data | ||
| #### Requirement 1: The Application Shall be Able to Load DICOM Data |
Contributor
There was a problem hiding this comment.
I wouldn't capitalize the requirements. While they are technically captions, they are semantically closer to an enumeration.
| The module `SynchroView2D` provides two 2D viewers that are synchronized. | ||
|
|
||
| As in Tutorial [Chapter 1 - Basic Mechanics of MeVisLab](tutorials/basicmechanisms/#TutorialParameterConnection), the processed and the unprocessed image can be displayed simultaneously. Scrolling through one image automatically changes the slices of both viewers, so slices with the same slice number are shown in both images. | ||
| As in tutorial [Chapter 1 - Basic Mechanics of MeVisLab](tutorials/basicmechanisms/#TutorialParameterConnection), the processed and the unprocessed image can be displayed simultaneously. Scrolling through one image automatically changes the slices of both viewers, so slices with the same slice number are shown in both images. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.