maskfilter: Tweak to clean filter #3165
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, those core voxels flagged for removal following erosion & connected component analysis would then be dilated in order to remove the full set of voxels deemed to be connected by a bridge smaller than or equal to the scale parameter. This could however lead to the removal of voxels that are part of the main connected component and not of the bridged component flagged for removal, yet were within the range of the dilation operation. This change constrains the removal of voxels from the mask based on per-iteration dilation, preventing that dilation from crossing voxels that are themselves not part of the original mask.
Conflicts: core/filter/mask_clean.h
|
clang-tidy review says "All clean, LGTM! 👍" |
Member
Author
|
First couple of attempts did not yield sample data that demonstrated a difference in behaviour between code versions. Shelving for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, those core voxels flagged for removal following erosion & connected component analysis would then be dilated in order to remove the full set of voxels deemed to be connected by a bridge smaller than or equal to the scale parameter. This could however lead to the removal of voxels that are part of the main connected component and not of the bridged component flagged for removal, yet were within the range of the dilation operation. This change constrains the removal of voxels from the mask based on per-iteration dilation, preventing that dilation from crossing voxels that are themselves not part of the original mask.
Found this while auditing branches. I only have a vague recollection of the issue. So might be difficult to find a dataset that properly exemplifies the difference.