-
Notifications
You must be signed in to change notification settings - Fork 2
MU EDS #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
michal-ruzicka
wants to merge
31
commits into
MITLibraries:master
Choose a base branch
from
michal-ruzicka:mu-eds
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
MU EDS #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
– All tabs substituted for four spaces. – Fixed indentation. – Added Vim modelines too keep the format seeting for next editings.
Keep the documentation only in correct Markdown formatted README.md file. The hardly editable, readable and versionable MS Office .docx file was removed.
Use of the current user (should be the Aleph system user account) $HOME environment variable should be more reliable then use of PWD.
sql_lookup.{cgi,csh} are properly generated from templates now.
Set sql_lookup configuration option to true in api_adapter.cgi if X-server is not available.
During the installation, ask for both Aleph User base Oracle schema name and Oracle user credentials of an user with the right reading this scheme. These values are used for sql_lookup.cgi template translation.
The provided locale value is used in responses to the ‘ilsinstance’ REST API calls.
Generate correct timezone info in responses to the ‘ilsinstance’ REST API requests.
Show these information in the debug mode only.
The variable contains a patron ID or an item ID depending on the object type we are interacting with.
The script is not directly used from the Internet so it is much better have it save as regular .pl Perl script – .pl files are not callable over the web server CGI interface by default.
Define all the possible REST API elements and decompose input URL to the elements so that the use of API can be precisely controled per function type.
This is useful if the real REST API URL differs from the default location as and we want to provide correct links in our REST API responses.
Proper REST request decomposition for circulationActions loans and cash subfunctions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various bug fixes and improvements of the middle ware.