Implement scipy.spatial.cKDTree for orthorhombic and no PBC #5193
+440
−148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5114
Changes made in this Pull Request:
-Added benchmarks/benchmarks/neighbors.py proving scipy.spatial.cKDTree is faster than the existing Implemetation.
-Implemented scipy.spatial.cKDTree backend in package/MDAnalysis/lib/pkdtree.py by building a new class.
-Updated testsuite/MDAnalysisTests/lib/test_pkdtree.py to verify both PeriodicKDTree (for API stability) and AugmentedPKDTree.
-Updated package/AUTHORS and package/CHANGELOG to reflect the contribution.
PR Checklist
package/CHANGELOGfile updated?package/AUTHORS? (If it is not, add it!)Developers Certificate of Origin
I certify that I can submit this code contribution as described in the Developer Certificate of Origin, under the MDAnalysis LICENSE.
📚 Documentation preview 📚: https://mdanalysis--5193.org.readthedocs.build/en/5193/