apidump: Ditch C++ templates to handle output format#2623
Draft
charles-lunarg wants to merge 1 commit intoLunarG:mainfrom
Draft
apidump: Ditch C++ templates to handle output format#2623charles-lunarg wants to merge 1 commit intoLunarG:mainfrom
charles-lunarg wants to merge 1 commit intoLunarG:mainfrom
Conversation
|
CI VulkanTools build queued with queue ID 645580. |
|
CI VulkanTools build # 5148 running. |
spencer-lunarg
approved these changes
Feb 11, 2026
|
CI VulkanTools build # 5148 passed. |
Speed up compilation by runtime managing formatting of the output stream rather than having template overloads for each output format type.
5785645 to
e02ae6e
Compare
|
CI VulkanTools build queued with queue ID 646279. |
|
CI VulkanTools build # 5149 running. |
|
CI VulkanTools build # 5149 passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Speed up compilation by runtime switching on the output format instead of having template overloads for each output format type.
Fixes #2524
Did a quick compilation test.
main: 08.937s
this branch: 03.347s
I have not done any verification of correctness of the output beyond making sure vkcube works at all. I also haven't checked if this adds dramatically worse overhead during runtime.