Skip to content

Conversation

@VonSquiggles
Copy link

Feature request made by another individual to specify serial number of hardware. Useful when trying to target one of multiple devices plugged in.

@Lauszus
Copy link
Owner

Lauszus commented Jul 7, 2022

I suggest you send a PR upstream instead, as I got the script merged into the python-can package: https://github.com/hardbyte/python-can/blob/develop/can/viewer.py

FYI please do not bump revision versions when sending a PR, as that should only be done when making a new release by the maintainer :)

@codecov
Copy link

codecov bot commented Jul 19, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (fbdc09a) to head (74ed831).

Additional details and impacted files
@@            Coverage Diff            @@
##            master        #4   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          256       257    +1     
  Branches        65        65           
=========================================
+ Hits           256       257    +1     
Files Coverage Δ
python_can_viewer/__init__.py 100.00% <100.00%> (ø)
python_can_viewer/python_can_viewer.py 100.00% <100.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants