Cross talk - Multi Channel Scan#337
Merged
tomeichlersmith merged 20 commits intomainfrom Dec 17, 2025
Merged
Conversation
…of a given parameter
Member
tomeichlersmith
left a comment
tomeichlersmith
left a comment
There was a problem hiding this comment.
Looks good, I just have two comments to help make the code more widely usable.
If the one about the decoding is too complicated, I'm also willing to just merge this and then I'll update it on my refactoring/tidying pass.
Member
|
This is now not compiling after your last commit 4a0ad77 Probably just a typo? But I don't want to mess with it in case its more complicated that it appears. |
Contributor
Author
|
Should be good to go! @tomeichlersmith |
tomeichlersmith
approved these changes
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New task
multi_channel_scanallows one to scan and analyze all channels at the same time, for an increasing number of pulsed channels per iteration. New functionadc_all_channelsinana/charge/parameter_timescan.pyplots the ADC vs channels and ADC vs time, including some RMS calculations for the output data. In the task function, there's the option of doing external charge injections with the LED L1A trigger, otherwise you can chose from preCC and highrange injections.