Skip to content

use correct slice type #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hoanguyenkh merged 2 commits into from
Jun 7, 2025
Merged

use correct slice type #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0cde13
use correct slice type
it4rb Jun 6, 2025
587ca5d
add test
it4rb Jun 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions cache/cache_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
package cache_test

import (
"github.com/KyberNetwork/kutils/cache"
"github.com/stretchr/testify/require"
"testing"
"time"

"github.com/KyberNetwork/kutils/cache"
"github.com/stretchr/testify/require"
)

func TestCache(t *testing.T) {
Expand Down Expand Up @@ -70,6 +71,18 @@ func TestCache(t *testing.T) {
require.NoError(t, err)
require.Equal(t, input, result)
})
t.Run("Slice Types", func(t *testing.T) {
sCache := cache.NewCache(ct.config)
key := "sliceTest"
input := []*example{{Name: "pointer", Age: 25, Value: 100}}
err := sCache.Set(key, input, time.Minute)
require.NoError(t, err)

var result []*example
err = sCache.Get(key, &result)
require.NoError(t, err)
require.Equal(t, input, result)
})

t.Run("Non-existent Key", func(t *testing.T) {
sCache := cache.NewCache(ct.config)
Expand Down
4 changes: 2 additions & 2 deletions cache/ristretto_cache.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ func alignTypes(target, value reflect.Value) reflect.Value {

// Handle slices within maps
if v.Kind() == reflect.Slice {
sliceType := reflect.TypeOf([]int{}) // Create the correct slice type
sliceType := value.Type() // Create the correct slice type
newSlice := reflect.MakeSlice(sliceType, v.Len(), v.Cap())

for i := 0; i < v.Len(); i++ {
Expand All @@ -138,7 +138,7 @@ func alignTypes(target, value reflect.Value) reflect.Value {

// Handle slice type conversion
if target.Kind() == reflect.Slice && value.Kind() == reflect.Slice {
sliceType := reflect.TypeOf([]int{})
sliceType := value.Type()
newSlice := reflect.MakeSlice(sliceType, value.Len(), value.Cap())
for i := 0; i < value.Len(); i++ {
elem := value.Index(i)
Expand Down