Add core settings, urls, pyproject.toml, and base.html#68
Open
VitalinaMykoliuk wants to merge 7 commits intoKostCode-Organization:mainfrom
Open
Add core settings, urls, pyproject.toml, and base.html#68VitalinaMykoliuk wants to merge 7 commits intoKostCode-Organization:mainfrom
VitalinaMykoliuk wants to merge 7 commits intoKostCode-Organization:mainfrom
Conversation
iamnovichek
requested changes
Jan 2, 2025
core/settings.py
Outdated
Comment on lines
177
to
178
| LOGIN_REDIRECT_URL = "/" | ||
| ACCOUNT_LOGOUT_REDIRECT_URL = "/" |
Collaborator
There was a problem hiding this comment.
Pls make it to redirect to /admin/
core/settings.py
Outdated
| LOGIN_REDIRECT_URL = "/" | ||
| ACCOUNT_LOGOUT_REDIRECT_URL = "/" | ||
|
|
||
| SITE_ID = 1 |
Collaborator
There was a problem hiding this comment.
Pls move it to .env file
core/settings.py
Outdated
| "APP": { | ||
| "client_id": os.environ.get("GITHUB_CLIENT_ID"), | ||
| "secret": os.environ.get("GITHUB_CLIENT_SECRET"), | ||
| "key": "", |
Collaborator
There was a problem hiding this comment.
Do we really need this key?
tracker/templates/base.html
Outdated
Collaborator
There was a problem hiding this comment.
You should sync with main because we already have a html file
iamnovichek
requested changes
Jan 14, 2025
core/settings.py
Outdated
| "allauth.account.auth_backends.AuthenticationBackend", | ||
| ) | ||
|
|
||
| LOGIN_REDIRECT_URL = os.environ.get("LOGIN_REDIRECT_URL") |
Collaborator
There was a problem hiding this comment.
No, this value should be hardcoded
core/settings.py
Outdated
| ) | ||
|
|
||
| LOGIN_REDIRECT_URL = os.environ.get("LOGIN_REDIRECT_URL") | ||
| ACCOUNT_LOGOUT_REDIRECT_URL = os.environ.get("ACCOUNT_LOGOUT_REDIRECT_URL") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.