feat(KeyboardShortcut): Add left and right arrow to cycle through images#611
Open
lchauvin wants to merge 3 commits intoKitware:mainfrom
Open
feat(KeyboardShortcut): Add left and right arrow to cycle through images#611lchauvin wants to merge 3 commits intoKitware:mainfrom
lchauvin wants to merge 3 commits intoKitware:mainfrom
Conversation
✅ Deploy Preview for volview-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
|
This does have an issue where not-yet reconstructed DICOM images aren't included in the cycling. I'm unifying the image list in #606, which should make this easier. |
Contributor
Author
|
Has the list of images been unified ? |
Collaborator
Contributor
|
I've given this some thought, so here are some ideas I had for this feature:
|
Contributor
Author
|
Should I wait for the backing store before making any modification ? |
Contributor
|
Revisiting this PR: we haven't had time to implement this. The idea (if you want to take it on) is to take the logic in ImageDataBrowser + PatientBrowser and move that into a store. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #610