Add GraphQL mutations for test measurement pinning#3437
Merged
williamjallen merged 5 commits intoKitware:masterfrom Feb 4, 2026
Merged
Add GraphQL mutations for test measurement pinning#3437williamjallen merged 5 commits intoKitware:masterfrom
williamjallen merged 5 commits intoKitware:masterfrom
Conversation
josephsnyder
approved these changes
Feb 4, 2026
Member
josephsnyder
left a comment
josephsnyder
left a comment
There was a problem hiding this comment.
LGTM! No issues with the ordering or creation of new pinned measurements.
I can't see the delete functionality because on the projects/###/testmeasurements page the delete button seems to be broken. It is not functioning in master either. I'll approve and let you decide if that should be a blocker
Collaborator
Author
|
@josephsnyder I'll address that in my upcoming refactor of this page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds mutations for creating, deleting, and updating the order of pinned test measurements. This will eventually replace
/api/v1/manageMeasurements.php.