Skip to content

Expose all project fields via GraphQL#3432

Merged
williamjallen merged 1 commit intoKitware:masterfrom
williamjallen:project-fields
Feb 3, 2026
Merged

Expose all project fields via GraphQL#3432
williamjallen merged 1 commit intoKitware:masterfrom
williamjallen:project-fields

Conversation

@williamjallen
Copy link
Collaborator

This PR adds all of the missing Project fields and solidifies the database types to better enforce our constraints. I plan to follow this work with a new updateProject mutation.

@williamjallen
Copy link
Collaborator Author

Requesting a double review again. I'm mostly looking for feedback on these things:

  • Naming choices
  • Types
  • Enum completeness
  • Test thoroughness

enum BugTracker {
GITHUB @enum(value: "GitHub")
BUGANIZER @enum(value: "Buganizer")
JIRA @enum(value: "JIRA")
Copy link
Contributor

@zackgalbreath zackgalbreath Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add GitLab issues as a supported type of bug tracker (not in this PR)

Copy link
Member

@josephsnyder josephsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With these latest changes, there are several more broken links that appear on the Project menu that would originally have been hidden or valid links. Each of the broken links seem to go to http://unknown :


                            <li>
                                <a class="cdash-link" ng-href="http://unknown" href="http://unknown">Home</a>
                            </li>
                            <!-- ngIf: cdash.documentation.replace('https://', '').replace('http://', '').trim() !== '' --><li ng-if="cdash.documentation.replace('https://', '').replace('http://', '').trim() !== ''" class="ng-scope">
                                <a class="cdash-link" ng-href="http://unknown" href="http://unknown">Documentation</a>
                            </li><!-- end ngIf: cdash.documentation.replace('https://', '').replace('http://', '').trim() !== '' -->
                            <!-- ngIf: cdash.vcs.replace('https://', '').replace('http://', '').trim() !== '' --><li ng-if="cdash.vcs.replace('https://', '').replace('http://', '').trim() !== ''" class="ng-scope">
                                <a class="cdash-link" ng-href="http://unknown" href="http://unknown">Repository</a>
                            </li><!-- end ngIf: cdash.vcs.replace('https://', '').replace('http://', '').trim() !== '' -->
                            <!-- ngIf: cdash.bugtracker.replace('https://', '').replace('http://', '').trim() !== '' --><li ng-if="cdash.bugtracker.replace('https://', '').replace('http://', '').trim() !== ''" ng-class="::{endsubmenu: cdash.projectrole}" class="ng-scope endsubmenu">
                                <a class="cdash-link" ng-href="http://unknown" href="http://unknown"> Bug Tracker</a>
                            </li><!-- end ngIf: cdash.bugtracker.replace('https://', '').replace('http://', '').trim() !== '' -->
                            <li class="endsubmenu">
                                <a class="cdash-link" ng-href="http://localhost:8080/projects/2/members" href="http://localhost:8080/projects/2/members">Members</a>
                            </li>
                                                            <li class="endsubmenu">
                                    <a class="cdash-link" ng-href="http://localhost:8080/subscribeProject.php?projectid=2" href="http://localhost:8080/subscribeProject.php?projectid=2">Notifications</a>
                                </li>

With master, the Home link was a pointer to CDash and the others were hidden,

Copy link
Member

@josephsnyder josephsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Links look good now, no other visible issues on manual testing,

@josephsnyder josephsnyder added this pull request to the merge queue Feb 3, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 3, 2026
@williamjallen williamjallen added this pull request to the merge queue Feb 3, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 3, 2026
This PR adds all of the missing Project fields and solidifies the database types to better enforce our constraints.  I plan to follow this work with a new `updateProject` mutation.
@williamjallen williamjallen added this pull request to the merge queue Feb 3, 2026
Merged via the queue into Kitware:master with commit 41c8954 Feb 3, 2026
7 checks passed
@williamjallen williamjallen deleted the project-fields branch February 3, 2026 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants