Expose all project fields via GraphQL#3432
Merged
williamjallen merged 1 commit intoKitware:masterfrom Feb 3, 2026
Merged
Conversation
Collaborator
Author
|
Requesting a double review again. I'm mostly looking for feedback on these things:
|
| enum BugTracker { | ||
| GITHUB @enum(value: "GitHub") | ||
| BUGANIZER @enum(value: "Buganizer") | ||
| JIRA @enum(value: "JIRA") |
Contributor
There was a problem hiding this comment.
We should add GitLab issues as a supported type of bug tracker (not in this PR)
zackgalbreath
approved these changes
Feb 3, 2026
25953fb to
8054b3c
Compare
josephsnyder
requested changes
Feb 3, 2026
Member
There was a problem hiding this comment.
With these latest changes, there are several more broken links that appear on the Project menu that would originally have been hidden or valid links. Each of the broken links seem to go to http://unknown :
<li>
<a class="cdash-link" ng-href="http://unknown" href="http://unknown">Home</a>
</li>
<!-- ngIf: cdash.documentation.replace('https://', '').replace('http://', '').trim() !== '' --><li ng-if="cdash.documentation.replace('https://', '').replace('http://', '').trim() !== ''" class="ng-scope">
<a class="cdash-link" ng-href="http://unknown" href="http://unknown">Documentation</a>
</li><!-- end ngIf: cdash.documentation.replace('https://', '').replace('http://', '').trim() !== '' -->
<!-- ngIf: cdash.vcs.replace('https://', '').replace('http://', '').trim() !== '' --><li ng-if="cdash.vcs.replace('https://', '').replace('http://', '').trim() !== ''" class="ng-scope">
<a class="cdash-link" ng-href="http://unknown" href="http://unknown">Repository</a>
</li><!-- end ngIf: cdash.vcs.replace('https://', '').replace('http://', '').trim() !== '' -->
<!-- ngIf: cdash.bugtracker.replace('https://', '').replace('http://', '').trim() !== '' --><li ng-if="cdash.bugtracker.replace('https://', '').replace('http://', '').trim() !== ''" ng-class="::{endsubmenu: cdash.projectrole}" class="ng-scope endsubmenu">
<a class="cdash-link" ng-href="http://unknown" href="http://unknown"> Bug Tracker</a>
</li><!-- end ngIf: cdash.bugtracker.replace('https://', '').replace('http://', '').trim() !== '' -->
<li class="endsubmenu">
<a class="cdash-link" ng-href="http://localhost:8080/projects/2/members" href="http://localhost:8080/projects/2/members">Members</a>
</li>
<li class="endsubmenu">
<a class="cdash-link" ng-href="http://localhost:8080/subscribeProject.php?projectid=2" href="http://localhost:8080/subscribeProject.php?projectid=2">Notifications</a>
</li>
With master, the Home link was a pointer to CDash and the others were hidden,
8054b3c to
d0244f4
Compare
josephsnyder
approved these changes
Feb 3, 2026
Member
josephsnyder
left a comment
There was a problem hiding this comment.
Links look good now, no other visible issues on manual testing,
This PR adds all of the missing Project fields and solidifies the database types to better enforce our constraints. I plan to follow this work with a new `updateProject` mutation.
d0244f4 to
ecea71a
Compare
This was referenced Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds all of the missing Project fields and solidifies the database types to better enforce our constraints. I plan to follow this work with a new
updateProjectmutation.