Connection direction #31
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 12, 2014 10:13
…A follows userB doesn't imply userB follows userA (one way connection) but userA is friend with userB (hopefully :D) does (two way connection)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If userA follows userB, trying to add userB as a follower of userA throws an exception as the users are already connected. I can see the value of keeping bidirectional connections (where whether a node is the source or the destination doesn't matter), for friend connections, for example, but one way connections should also be possible. I've kept the default behaviour to two-ways connections in order not to introduce backward incompatibilities. Also, there might be more changes needed, for now only the Manager::connect and Repository::areConnected are aware of the direction of the connection.