Draft
Conversation
* Clean up events on EVM reversion in try-catch * backport v0.4.x-specific function layout * yihuang-patch adaptation for v0.4.x Adds balance handler factory to un-refactored precompile code, adapting it for Distribution, Staking, Slashing, ICS20, and Gov. Skips the ERC20 as that one did not yet make use of the balance handler in v0.4.x. * Fix unit test * Add adapted test for v0.4.x Added balance handler test, adapted for the v0.4.x precompile structure. Uses a decomposed version of the p.RunSetup function without the method checks. * Add debug json * add debug comments * fix imports
see: cosmos/evm#607 Signed-off-by: David Pierret <dapie@cros-nest.com>
…ual chain id see: cosmos/evm#918 Signed-off-by: David Pierret <dapie@cros-nest.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With the current binary (evm v0.4.2), we are not able to use Ledger.
patch made on the branch
feat/fork-v0.4.2and rebased tomainAfter this patch is applied, we are able to sign and verify a transaction
But the transaction is rejected by the RPC if it doesn't have the fix.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
mainbranch