Skip to content

Conversation

@DoumanAsh
Copy link

This defaults to using aws's crypto lib if both features are enabled to make sure jsonwebtoken can be used

Genenrally everything should be re-written to make backend pluggable like in rustls, but this is the most simplest approach to work around issue of using jsonwebtoken in complex dependency tree

This defaults to using aws's crypto lib if both features are enabled to make sure jsonwebtoken can be used

Genenrally everything should be re-written to make backend pluggable like in rustls, but this is the most simplest approach to work around issue of using jsonwebtoken in complex dependency tree
@Keats
Copy link
Owner

Keats commented Dec 18, 2025

There is a PR to implement something like rustls: #452

@DoumanAsh
Copy link
Author

DoumanAsh commented Dec 18, 2025

Didn't notice one, I suppose I will wait for it to be implemented in order to fix build

@DoumanAsh DoumanAsh closed this Dec 18, 2025
@DoumanAsh DoumanAsh deleted the feature_selection branch December 18, 2025 14:58
@Keats
Copy link
Owner

Keats commented Dec 18, 2025

If you have time, please review as well, i'm not familiar with the pluggable backend pattern

@DoumanAsh
Copy link
Author

Ok, I looked briefly and it is not in state to be ready merged, so I left some comments
But jsonwebtoken has legitimate problem with being dependency as libraries cannot use it without either crypto feature, so depending on library that depends on jsonwebtoken is very dangerous, if PR is going to drag on, I may create another PR to implement pluggable backend myself as alternative

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants