fix(style-code): Resolve static analysis errors and improve type safety#16
Merged
walmir-silva merged 1 commit intomainfrom Jul 31, 2025
Merged
fix(style-code): Resolve static analysis errors and improve type safety#16walmir-silva merged 1 commit intomainfrom
walmir-silva merged 1 commit intomainfrom
Conversation
This commit addresses a series of issues identified by PHPStan, enhancing the overall type safety and robustness of the data structures. - **BinaryHeap:** Corrected type inference by specifying the heap property as a `list`, which eliminates the need for explicit integer casting when removing elements. - **TreeMap/TreeMapNode:** Fixed a potential null pointer exception in `balanceAfterInsertion` by adding a safety check for the grandparent node. - **HashMap:** Refactored to use a consistent internal key handling mechanism, resolving type errors and adding proper support for object keys. - **ArrayList:** Fixed a `Cannot cast mixed to string` error by explicitly handling the `resource` type. - **phpstan.neon:** Cleaned up the configuration by removing obsolete ignored error patterns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit addresses a series of issues identified by PHPStan, enhancing the overall type safety and robustness of the data structures.
list, which eliminates the need for explicit integer casting when removing elements.balanceAfterInsertionby adding a safety check for the grandparent node.Cannot cast mixed to stringerror by explicitly handling theresourcetype.