use extensions instead of requires when usable #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@lucaferranti Would it be possible to merge and release ? We had to temporarily remove this package as dependency from Dionysos as it is failing on Julia v1.12 |
Contributor
|
Maybe it would be good to retrigger ci now that Julia v1.12 has been released. I tested locally with v1.12.2 and the tests pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the package on 1.12 (failing due to both LazySets and IntervalLinearAlgebra defining an
Intervarlname).Tangentially, this package also fails on 1.6 due to using
BLAS.lbt_forward, which is not defined there. Might warrant a bump to julia 1.10.