[CI] Merge docker images across platforms #3003
Draft
+99
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
force-pushed
the
mg/gha-merge-docker-arch
branch
2 times, most recently
from
644af9f to
620d127
Compare
With the current setup, images for different platforms are pushed with the same tag, overriding each other. With this change, instead, images built for different architectures are merged together. [skip ci]
giordano
force-pushed
the
mg/gha-merge-docker-arch
branch
from
620d127 to
b82dc4d
Compare
giordano
commented
Dec 24, 2025
Comment on lines
-102
to
-108
| tags: | | ||
| type=raw,value=${{ steps.pkg.outputs.name }}-julia${{ matrix.julia }}-cuda${{ steps.cuda.outputs.major }} | ||
| type=raw,value=${{ steps.pkg.outputs.name }},enable=${{ matrix.default == true && (github.ref_type == 'tag' || inputs.tag != '') }} | ||
| type=raw,value=latest,enable=${{ matrix.default == true && (github.ref_type == 'tag' || (inputs.tag != '' && inputs.mark_as_latest)) }} | ||
| type=raw,value=dev,enable=${{ matrix.default == true && github.ref_type == 'branch' && inputs.tag == '' }} | ||
| labels: | | ||
| org.opencontainers.image.version=${{ steps.pkg.outputs.version }} |
Contributor
Author
There was a problem hiding this comment.
I honestly don't quite understand what was going on here. If anything needs to be adapted, it should be done in the tags input in the Build and push image step below.
Contributor
Author
|
See for example https://github.com/giordano/CUDA.jl/pkgs/container/cuda.jl/622078126?tag=dev-julia1.11-cuda12, where the tag has both architectures, instead of only the last one which happened to have been pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current setup, images for different platforms are pushed with the same tag, overriding each other. With this change, instead, images built for different architectures are merged together. I still need to do some more testing, but something like this should do the trick.