Added additional call function for passing an array of arguments (e.g. with user input)#83
Open
WebFreak001 wants to merge 2 commits intoJakobOvrum:masterfrom
Open
Added additional call function for passing an array of arguments (e.g. with user input)#83WebFreak001 wants to merge 2 commits intoJakobOvrum:masterfrom
WebFreak001 wants to merge 2 commits intoJakobOvrum:masterfrom
Conversation
Owner
|
Needs a unit test. Also, it looks like it would conflict with the existing call function. What should happen with the following code? function myFunction(a)
print(type(a))
endauto myFunction = lua.get!LuaFunction("myFunction");
myFunction.call([1]);Should it print Maybe it should be a separate function named something like |
Author
|
thats a good idea to rename it but i dont know nothing about unit tests so I cant add it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because for my function luaEmitEvent(A)(string type, A[] args...) I coulnd't pass an array I made this modification