This repository was archived by the owner on Jun 5, 2022. It is now read-only.
Add 'customIcon' parameter to allow for setting a custom icon. Needed…#244
Open
nimbus2300 wants to merge 4 commits intoJakeHartnell:masterfrom
Open
Add 'customIcon' parameter to allow for setting a custom icon. Needed…#244nimbus2300 wants to merge 4 commits intoJakeHartnell:masterfrom
nimbus2300 wants to merge 4 commits intoJakeHartnell:masterfrom
Conversation
… for dark mode support. I have purposefully kept this change simple rather than do anything elaborate w.r.t Dark-mode support.
3imed-jaberi
approved these changes
Oct 4, 2021
Author
|
Ready for merge |
Author
|
Apologies I accidentally closed the PR trying to work out how to merge it. I think the merge needs to happen by an authorised maintainer. I've reopened this PR request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… for dark mode support on the upload-icon.
Summary of changes:
I have purposefully kept this change simple rather than do anything elaborate w.r.t Dark-mode support.