Introduction of the Calories workout type, various improvements#158
Open
JaapvanEkris wants to merge 246 commits intomainfrom
Open
Introduction of the Calories workout type, various improvements#158JaapvanEkris wants to merge 246 commits intomainfrom
JaapvanEkris wants to merge 246 commits intomainfrom
Conversation
* First Pass: Refactor settings and controls into separate toolbar component * Fix layout padding calculation to prevent vertical overflow scrolling * Added migration logic to remove 'actions' from saved dashboardMetrics in localStorage. * Cleaned up Dashboard CSS. * Refine and make explicit the layout for PerformanceDashboard. * Make chart font sizes responsive using em-based calculations. * Refactor DashboardForceCurve, removed any/all labels from ForceCurve. * Standardized bottom padding to all tiles * Maximize chart height in forceCurve
* Adding new CSS theme. * Apply `theme-widget-border` to all instances elements using `theme-widget-color` * Add True Black theme toggle option to settings dialog * Remove theme-widget-border CSS variable and update true-black buttons to also be black (floating icons)
* Update BLE pairing flow (fixes #169) - Fix incorrect CPS Control Point UUID - Add Security Manager to the GATT Connection to handle pairing requests * Update ble-host dependency to use forked repo Use the forked version of ble-host that fixes packet size calculation on small MTU.
* Moved chart data update logic from render() to `shouldUpdate` to keep logic simple and renders down.
Corrected several minor typos (e.g., "alrrady", "recieve", "recomended") to improve overall readability.
* fix: correct FTMS Control Point error codes per Bluetooth spec The FTMS Control Point characteristic returned wrong result codes in several cases: - reset/startOrResume/stopOrPause without prior requestControl returned opCodeNotSupported (0x02) instead of controlNotPermitted (0x05) - stopOrPause with invalid parameter (not 1 or 2) returned opCodeNotSupported instead of invalidParameter (0x03) - stopOrPause with a truncated 1-byte buffer caused a RangeError crash (buffer underflow) that prevented indicate+callback from being called, hanging the BLE stack Also removes dead fallthrough code — all handled cases now return explicitly, so only the default case produces opCodeNotSupported. Adds 11 uvu tests covering all control point code paths. * refactor: use guard clauses in FTMS control point handler
* fix: correct FTMS Control Point error codes per Bluetooth spec The FTMS Control Point characteristic returned wrong result codes in several cases: - reset/startOrResume/stopOrPause without prior requestControl returned opCodeNotSupported (0x02) instead of controlNotPermitted (0x05) - stopOrPause with invalid parameter (not 1 or 2) returned opCodeNotSupported instead of invalidParameter (0x03) - stopOrPause with a truncated 1-byte buffer caused a RangeError crash (buffer underflow) that prevented indicate+callback from being called, hanging the BLE stack Also removes dead fallthrough code — all handled cases now return explicitly, so only the default case produces opCodeNotSupported. Adds 11 uvu tests covering all control point code paths. * refactor: use guard clauses in FTMS control point handler * feat: add software debounce filter for GPIO magnetic sensor Hardware bounce from magnetic flywheel sensors can send phantom ticks (~0.5ms apart) that corrupt stroke data. This middleware layer filters bounces by validating delta-times against a rolling median buffer. - Rejects deltas below 1ms (absolute minimum) - Rejects deltas below 40% of median (physically impossible acceleration) - Uses fixed-size circular buffer for performance (no allocations in hot path) * refactor: remove GPIO debounce filter based on maintainer feedback, retain FTMS fixes * fix: restore maintenance comments in GpioTimerService.js Comments were unintentionally removed when stripping the debounce filter changes. File now matches the base branch with no modifications.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New functionality in 0.9.7
Bugfixes and robustness improvements in 0.9.7
Flyhweel.jsas all dependent algorithms can use the same datastream. It reduces noise on the reference system from 1.5% (version 0.9.6) to 0.3% (version 0.9.7).Flywheel.js, allowing a more thorough testing of this function's behaviourFlywheel.js