Skip to content

Conversation

@matthewrmshin
Copy link
Collaborator

@matthewrmshin matthewrmshin commented Apr 4, 2025

Description

Need to reconsider whole dict/list again if merge include results in another merge include.

Issue

Resolves #35

Checklist

  • I have performed a self-review of my own code
  • I have run the unit tests before creating the PR

Need to reconsider whole dict/list again if merge include results in
another merge include.
@matthewrmshin matthewrmshin added the bug Something is not working label Apr 4, 2025
@matthewrmshin matthewrmshin self-assigned this Apr 4, 2025
Copy link
Contributor

@twsearle twsearle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally against all global-ocean configs, and there are no more sneaky INCLUDES or env variables I can see. I think this is enough for me to approve the merge, although we probably want to retry teh build in sith before handing it over for PS47.

@matthewrmshin
Copy link
Collaborator Author

I have built a wheel and installed it as 0.6.5rc1 on mobbs-59 on exab and excd. The failed daily tests are now back to life.

@twsearle
Copy link
Contributor

twsearle commented Apr 4, 2025

@twsearle
Copy link
Contributor

twsearle commented Apr 4, 2025

all looks good to me - even the OSTIA one that was failing in monitoring last Ichecked.

@twsearle twsearle merged commit d2b6de1 into develop Apr 4, 2025
3 checks passed
@matthewrmshin matthewrmshin deleted the bugfix/recursive-merge-include branch April 4, 2025 13:00
@matthewrmshin matthewrmshin added this to the next-release milestone Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something is not working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Merging empty lists halts subsequent environment variable processing

3 participants