Skip to content
This repository was archived by the owner on Apr 20, 2025. It is now read-only.

Conversation

@oxkitsune
Copy link
Member

@oxkitsune oxkitsune commented Apr 2, 2025

This also checks the Cargo.lock file in? It wasn't for some reason.

@oxkitsune oxkitsune self-assigned this Apr 2, 2025
@oxkitsune oxkitsune requested review from Aemulation, YukumoHunter and Copilot and removed request for Aemulation April 2, 2025 20:37
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the CoppeliaSim backend from the project and updates related documentation, error handling, module usage, and dependency management.

  • Removed CoppeliaSim backend documentation and code from the library.
  • Removed error variants and module exports related to CoppeliaSim.
  • Updated Cargo.toml to drop the CoppeliaSim dependency and bump the package version.

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
nidhogg/src/lib.rs Documentation update: removed CoppeliaSim backend entry from the supported backends table.
nidhogg/src/error.rs Removed the CoppeliaConnectError error variant.
nidhogg/src/backend/mod.rs Removed module import and public re-export for CoppeliaSim.
nidhogg/src/backend/coppelia.rs Removed the entire file implementing the CoppeliaSim backend.
nidhogg/examples/generic_backend.rs Removed commented instantiation of the CoppeliaSim backend.
nidhogg/Cargo.toml Dropped the CoppeliaSim dependency and updated the version to 0.7.0.

Copy link
Member

@YukumoHunter YukumoHunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😭

@oxkitsune oxkitsune merged commit a8851d1 into main Apr 2, 2025
4 checks passed
@oxkitsune oxkitsune deleted the gijs/drop-coppelia-sim branch April 2, 2025 20:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants