issue/838 - Cambricon Batched RoPE #839
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds support for batched RoPE (Rotary Position Embedding) operations in the Cambricon BANG backend by extending the kernel to handle a batch dimension in input tensors.
Key Changes:
- Extended RoPE kernel to process 4D tensors with batch dimension [batch, seqlen, nhead, dhead]
- Updated task distribution to handle batch_size × seqlen × nhead workload
- Added batch stride parameters for input and output tensors
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/infiniop/ops/rope/bang/rope_bang_kernel.mlu |
Updated kernel signature with batch_size and stride parameters; modified task distribution and index calculations to handle batched inputs; added logic to handle position IDs with or without batch dimension |
src/infiniop/ops/rope/bang/rope_bang.mlu |
Updated variable names for clarity (dimx→seqlen, dimy→nhead); added batch_size parameter extraction; updated kernel launch to pass batch dimension and stride parameters |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #838
