Skip to content

[WIP] Prefab refacto #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ncannasse wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[WIP] Prefab refacto #205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ba46dbe
delete non-core prefabs
ncannasse Sep 19, 2021
3cdd3ea
added -D prefab_refacto to disable some deleted prefabs
ncannasse Sep 19, 2021
50cc356
removed Instance
ncannasse Jan 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions hide.hxml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,4 @@ common.hxml
--macro include("hrt.shgraph.nodes")
-dce no
-debug
-D prefab_refacto
2 changes: 1 addition & 1 deletion hide/comp/SceneEditor.hx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2159,7 +2159,7 @@ class SceneEditor {
var prevIndex = prev.children.indexOf(elt);

var obj3d = elt.to(Object3D);
var preserveTransform = Std.is(toElt, hrt.prefab.fx.Emitter) || Std.is(prev, hrt.prefab.fx.Emitter);
var preserveTransform = #if prefab_refacto false #else Std.is(toElt, hrt.prefab.fx.Emitter) || Std.is(prev, hrt.prefab.fx.Emitter) #end;
var toObj = getObject(toElt);
var obj = getObject(elt);
var prevState = null, newState = null;
Expand Down
Loading