Update BuildSearchDirectories documentation to reflect removal of sibling check#13
Merged
HandyS11 merged 2 commits intorefacto/ImproveCodeQualityfrom Feb 3, 2026
Merged
Conversation
…ling check Co-authored-by: HandyS11 <62420910+HandyS11@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Apply feedback from review on code quality improvements
Update BuildSearchDirectories documentation to reflect removal of sibling check
Feb 3, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates the XML documentation for the BuildSearchDirectories method to reflect the removal of the AddSiblingEntityDirectories method and associated sibling check logic. The documentation had become outdated after commit 07ffa2f removed the sibling check functionality.
Changes:
- Removed outdated reference to "sibling check fallback" that no longer exists
- Removed reference to non-existent
entityNamespacesparameter in the summary - Clarified that the method searches the context directory and parent directory, with recursive parent scanning naturally including siblings
Comments suppressed due to low confidence (2)
src/ProjGraph.Lib/Services/EfAnalysis/EntityFileDiscovery.cs:205
- This foreach loop immediately maps its iteration variable to another variable - consider mapping the sequence explicitly using '.Select(...)'.
foreach (var csFile in Directory.EnumerateFiles(searchDir, EfAnalysisConstants.FilePatterns.CSharpFiles,
options))
{
var fullPath = Path.GetFullPath(csFile);
if (fullPath.Equals(normalizedContextPath, StringComparison.OrdinalIgnoreCase))
{
continue;
}
// Skip common non-source directories that can be large
var pathSegments = fullPath.Split(Path.DirectorySeparatorChar, Path.AltDirectorySeparatorChar);
if (pathSegments.Any(s => s is "bin" or "obj" or ".git" or "node_modules"))
{
continue;
}
await ProcessSourceFileAsync(fullPath, entityTypeNames, entityFiles);
}
src/ProjGraph.Lib/Services/EfAnalysis/EntityFileDiscovery.cs:276
- This foreach loop immediately maps its iteration variable to another variable - consider mapping the sequence explicitly using '.Select(...)'.
foreach (var entityFile in entityFiles.Values.Distinct())
{
var entityCode = await File.ReadAllTextAsync(entityFile);
var entityTree = CSharpSyntaxTree.ParseText(entityCode);
var entityRoot = await entityTree.GetRootAsync();
ExtractBaseClassNamesFromSyntax(entityRoot, baseClassNames);
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The XML documentation for
BuildSearchDirectoriesreferenced a sibling check fallback that no longer exists. TheAddSiblingEntityDirectoriesmethod was removed in commit 07ffa2f, but the documentation wasn't updated.Changes:
entityNamespacesparameter in summary💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.