-
Notifications
You must be signed in to change notification settings - Fork 0
Added Tess' machine-learning on RXTE data notebook contents into the existing RXTE notebook #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DavidT3
wants to merge
13
commits into
main
Choose a base branch
from
notebook/addMLToExistingRXTE
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto analyze-rxte-spectra.md. For issue #111
…notebook. For issue #111
…code back in to the notebook in the ML sections. It is compatible with how information is already loaded in, and includes some optimizations/improvements. Still no commentary, and the plotting code will be improved more. For issue #111
… notebook. For issue #111
…ly on the mean cluster spectra section. For issue #111
…E notebook. For issue #111
…nd changes to Xamin must have kicked in I suppose! Puts issue #111 into PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HEASARC notebook review
Didn't seem to make sense having another notebook for the machine learning aspect, like there was in the SciServer cookbooks, as a big chunk of it was replicated (the acquisition of the spectra etc.)
So in ingesting that notebook I have added it as a section to the existing RXTE spectral analysis notebook - the combination lets us do some interesting things looking at how model-independent classification compares with fitted model parameters as well.
Re-written the code, and added a lot more commentary.
Critical review criteria
The author of the pull request should make an effort to go through these check points and ensure that their submission satisfies each point - reviewers will also compare to these checklists.
Science review checklist
Formatting checklist
Tech review checklist
try/exceptstatements that are narrow in scope?