Return of WebSocket test and adding comments#118
Open
tukanos wants to merge 2 commits intoGsDevKit:gs_masterfrom
Open
Return of WebSocket test and adding comments#118tukanos wants to merge 2 commits intoGsDevKit:gs_masterfrom
tukanos wants to merge 2 commits intoGsDevKit:gs_masterfrom
Conversation
tukanos
force-pushed
the
ReturnOfWebSocketTests
branch
from
2dd6ae3 to
b048b90
Compare
tukanos
changed the title
tukanos
changed the title
Author
|
The issue with the enabled test is that the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this patch I'm adding comments to make it clear that these tests need to be run in the correct context.
I'm also activating test:
testEchoSecureWebSocketsDotOrgwhich was deactivated due tohttps://github.com/GsDevKit/zinc/issues/96. The issue was/is thatwebserver.orghave disabled the plain textws://protocol and support only the secure version of itwss://.I have removed the code that skips the tests and added a comment for the
ws://protocol explaining the situation.