Closed
Conversation
added 30 commits
November 21, 2025 09:25
Classes had to be split into each environment test package even thou the classes are very similar
This reverts commit 06c4528.
This reverts commit d646353.
This reverts commit e29e827.
This reverts commit 669d919.
This reverts commit ab3043a.
Part of zinc already loaded into Globals dictionary we have get all the files back and move the code from the -gemstone- package into .v37 package. Otherwise we would get a conflict between Zinc version in Globals and UserGlobals.
The class is identical to what is in -Core package, but in GemStone in must be as extension since the class has been already loaded into Globals dictionary.
The class inheritance tree is different in Pharo and GemStone. Must adjust for that.
added 29 commits
January 16, 2026 15:22
Adding also a test which tests its functionality
The reason for reverting is presence of Announcements repository which uses the Pharo functionality in GemStone. It is much more complete that my patch. This reverts commit 7608a8e.
This bug/race condition occurred when waiting for data and connection got closed in meantime. readyForRead was usually nil as the connection closed which then created the condition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this patch I'm adding methods (also comments) to make it clear that these tests need to be run in the correct context.
I'm also activating test:
testEchoSecureWebSocketsDotOrgwhich was deactivated due tohttps://github.com/GsDevKit/zinc/issues/96. The issue was/is thatwebserver.orghave disabled the plain textws://protocol and support only the secure version of itwss://.I have removed the code that skips the tests and added a comment for the
ws://protocol explaining the situation.