Skip to content

feat: Improve DeviceType proposal #2381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
havogt wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: Improve DeviceType proposal #2381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/gt4py/_core/definitions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,6 +378,7 @@ class DeviceType(enum.IntEnum):
https://github.com/dmlc/dlpack/blob/main/include/dlpack/dlpack.h
"""

INVALID_DEVICE = -1
CPU = 1
CUDA = 2
# CPU_PINNED = 3 # noqa: ERA001
Expand All @@ -388,11 +389,18 @@ class DeviceType(enum.IntEnum):
ROCM = 10
# CUDA_MANAGED = 13 # noqa: ERA001
# ONE_API = 14 # noqa: ERA001
GPU = ( # TODO whatever makes sense
CUDA
if cp is not None
and not (cp.cuda.runtime.is_hip if hasattr(cp.cuda.runtime, "is_hip") else False)
else ROCM
)


CPUDeviceTyping: TypeAlias = Literal[DeviceType.CPU]
CUDADeviceTyping: TypeAlias = Literal[DeviceType.CUDA]
ROCMDeviceTyping: TypeAlias = Literal[DeviceType.ROCM]
GPUDeviceTyping: TypeAlias = Literal[DeviceType.GPU]


DeviceTypeT = TypeVar(
Expand All @@ -403,9 +411,7 @@ class DeviceType(enum.IntEnum):
)


CUPY_DEVICE_TYPE = (
None if not cp else (DeviceType.ROCM if cp.cuda.runtime.is_hip else DeviceType.CUDA)
)
CUPY_DEVICE_TYPE = DeviceType.GPU


@dataclasses.dataclass(frozen=True)
Expand Down
2 changes: 1 addition & 1 deletion src/gt4py/next/allocators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ def is_field_allocation_tool(obj: Any) -> TypeGuard[FieldBufferAllocationUtil]:

def is_field_allocation_tool_for(
obj: Any, device: core_defs.DeviceTypeT
) -> TypeGuard[FieldBufferAllocationUtil]:
) -> TypeGuard[FieldBufferAllocationUtil[core_defs.DeviceTypeT]]:
return is_field_allocator_for(obj, device) or is_field_allocator_factory_for(obj, device)


Expand Down
Loading