Add Ubuntu build automation via PNNL GitLab#195
Add Ubuntu build automation via PNNL GitLab#195jacksavage wants to merge 197 commits intodevelopfrom
Conversation
- Split the script into two (one for installing dependencies and other for GridPACK) - Ignore boost includes and boost libraries in GridPACK.cmake.in. Otherwise python installation fails. - Update GridPACK installation script with addition CMake flags for Boost.
- Remove directory changes and assume current directory - Use local variables in functions - Capture logs
Missing bash causes issues sourcing lib script
|
The Rocky Linux jobs in |
This looks like the Python development package ( |
wperkins
left a comment
There was a problem hiding this comment.
I think this is fine, but, the two scripts that were deleted still need to function outside of the container environment. These were sort of generic before. It would be good to retain that and still work on an OS other than the containers used (Debian, e.g).
There was a problem hiding this comment.
I'm concerned that this script no longer stands alone. Somewhere in the documentation, new users were directed to use this script to install GridPACK dependencies. Does it work outside of the container environment?
There was a problem hiding this comment.
Has this been tested outside of the container environment?

install_package_deps_lib.shto install packages to each container image based on the detected distribution.install_gridpack.sh.install_from_source_deps.sh(wasinstall_gridpack_deps.sh) and breaks out pieces intoinstall_boost.sh,install_ga.sh, andinstall_petsc.sh..gitlab-ci.yml. this contains 1) jobs to test if the container image needs rebuilt, 2) a job to build a container image used as the environment for subsequent jobs, 3) a job that installs gridpack, and 4) a job that runs the tests for that gridpack installation.dockerfilewhich is the definition for the container image to be built. besides setting environment variables, this usesinstall_boost.sh,install_ga.sh,install_petsc.sh, andinstall_gridpack_deps.sh.