-
Notifications
You must be signed in to change notification settings - Fork 1
Upgrade ami release #210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Upgrade ami release #210
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
tests/daemonset.yaml
Outdated
| operator: "Equal" | ||
| value: "glueops-platform-argocd-app-controller" | ||
| effect: "NoSchedule" | ||
| containers: |
Check warning
Code scanning / SonarCloud
Service account permissions should be restricted Medium test
tests/daemonset.yaml
Outdated
| value: "glueops-platform-argocd-app-controller" | ||
| effect: "NoSchedule" | ||
| containers: | ||
| - name: alpine |
Check warning
Code scanning / SonarCloud
Memory limits should be enforced Medium test
tests/daemonset.yaml
Outdated
| operator: "Equal" | ||
| value: "glueops-platform" | ||
| effect: "NoSchedule" | ||
| containers: |
Check warning
Code scanning / SonarCloud
Service account permissions should be restricted Medium test
tests/daemonset.yaml
Outdated
| value: "glueops-platform" | ||
| effect: "NoSchedule" | ||
| containers: | ||
| - name: alpine |
Check warning
Code scanning / SonarCloud
Memory limits should be enforced Medium test
tests/daemonset.yaml
Outdated
| labels: | ||
| app: alpine-test | ||
| spec: | ||
| containers: |
Check warning
Code scanning / SonarCloud
Service account permissions should be restricted Medium test
tests/daemonset.yaml
Outdated
| app: alpine-test | ||
| spec: | ||
| containers: | ||
| - name: alpine |
Check warning
Code scanning / SonarCloud
Memory limits should be enforced Medium test
|



PR Type
Enhancement, Tests
Description
Updated AMI release version across multiple files to
1.30.8-20250123.Added a new test for pod creation using a DaemonSet in Kubernetes.
Introduced a new
daemonset.yamlfile for testing pod creation.Enhanced cleanup and validation steps in
k8s-test.sh.Changes walkthrough 📝
main.tf
Update AMI release version in Terraform test configurationstests/main.tf
1.30.8-20250123in commentedconfigurations.
variables.tf
Update default AMI release versionvariables.tf
1.30.8-20250123.k8s-test.sh
Add pod creation test and cleanup in scripttests/k8s-test.sh
daemonset.yaml
Add DaemonSet configuration for pod creation testingtests/daemonset.yaml
README.md
Update AMI release version in README examplesREADME.md
1.30.8-20250123in exampleconfigurations.
.header.md
Update AMI release version in documentation headerdocs/.header.md
1.30.8-20250123in documentation headerexamples.