Skip to content

Conversation

@hib4
Copy link
Member

@hib4 hib4 commented May 22, 2025

No description provided.

@hib4 hib4 self-assigned this May 22, 2025
@hib4 hib4 merged commit 33e1a21 into main May 22, 2025
1 check passed
@github-actions
Copy link

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
General
Preserve backward compatibility for endpoints

Changing the route from /request-reset to /reset-password may break existing clients
expecting the old endpoint. Ensure that this change is intentional and that all
clients are updated accordingly, or consider supporting both endpoints for backward
compatibility.

functions/src/routes/auth.ts [15]

+router.post("/request-reset", requestPasswordReset);
 router.post("/reset-password", requestPasswordReset);
Suggestion importance[1-10]: 7

__

Why: The suggestion to keep both the old and new endpoints helps prevent breaking changes for existing clients, which is important for API stability. However, it is not a critical bug fix, so the score is moderate.

Medium
Use generic support email address

Changing the support email address to a personal email (hiba@garudahacks.com) may
expose sensitive information and reduce professionalism. Use a generic support email
(e.g., support@garudahacks.com) to avoid privacy and operational issues.

functions/src/controllers/auth_controller.ts [462]

-<a href="mailto:hiba@garudahacks.com" style="color: #718096; text-decoration: none;">Contact Support</a>
+<a href="mailto:support@garudahacks.com" style="color: #718096; text-decoration: none;">Contact Support</a>
Suggestion importance[1-10]: 7

__

Why: Recommending the use of a generic support email instead of a personal one improves professionalism and privacy, which is important for production systems, but it is not a critical security or functional issue.

Medium

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants