-
Notifications
You must be signed in to change notification settings - Fork 56
Create Mac application bundle #184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This is so cool!! |
|
Very neat @pazner! Had a few comments/suggestions:
|
Yes, I just added a CMake target.
I agree, I can generate the icns file from the SDL icon with ImageMagick and iconutil. If we had a PNG format icon instead of raw RGBA data, we could generate the icns using only iconutil (which comes standard with Mac OS). mkdir -p GLVis.iconset
convert -size 1024x1024 -depth 8 logo.rgba GLVis.iconset/icon_512x512@2x.png
iconutil --convert icns GLVis.iconset
rm -r GLVis.iconset
I don't think you need code-signing to run an app that you compile yourself, only to distribute it. It would be good to test this though. |
|
@kanye-quest, see the branch mac-app-icon for an example of creating the icns file directly from the RGBA data. Instead of ImageMagick, I used the Mac's AppKit APIs to convert to PNG. Since if we are building a Mac app bundle, it's probably OK to depend on having Mac SDKs. That being said, it might be more hassle than it's worth compared with just including the ~ 1 MB icon file. |
|
If you don't want to see the Is it possible to add something to the dialog for the "About GLVis" menu item? Currently it only shows the GLVis logo, it will be nice to at least link to the website. |
Thanks @pazner! I adjusted the text a bit -- feel free to edit further if you'd like. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome, thanks for thinking about it and making it happen @pazner 🎉
- Please mention in
CHANGELOG
|
@kanye-quest and @tomstitt -- do you need more time to review this? (totally fine if you do, just checking) |
tomstitt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just wanted to try it out! Very cool, nice work @pazner !
publixsubfan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.


Now that #174 was merged and GLVis behaves more like a standard Mac application (only once instance is running, single Dock icon vs. many icons, etc.), it might make sense to also package GLVis as a Mac application bundle ("GLVis.app") that can be double-clicked, added to the Dock, and so on.
This PR adds a makefile target (
make app) that does that. It does require adding an icns file (~ 960 KB) to the repo.