Skip to content

Conversation

@sahiljhawar
Copy link
Collaborator

This PR closes #21

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new boolean interpolation parameter to control spline interpolation for short gaps in historical solar wind data. Previously, interpolation was always applied when historical data was available, but now it can be optionally disabled.

Key changes:

  • Added interpolation parameter with default False to control interpolation behavior
  • Updated function signatures and parameter passing throughout the call chain
  • Modified interpolation flag setting to be conditional based on the parameter

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
swvo/io/solar_wind/read_solar_wind_from_multiple_models.py Added interpolation parameter to main function and helper functions, made interpolation conditional
tests/io/solar_wind/test_read_solar_wind_from_multiple_models.py Updated test calls to explicitly set interpolation=True

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@DoctorRabbit55 DoctorRabbit55 merged commit 07f8527 into GFZ:main Sep 23, 2025
8 checks passed
@sahiljhawar sahiljhawar deleted the interpolation-flag branch September 23, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

use flag for interpolation in solar_wind

2 participants