-
Notifications
You must be signed in to change notification settings - Fork 0
Return question scores and recalculate #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return question scores and recalculate #1
Conversation
|
❗ The branch name In order to correctly link this PR to an issue, the branch name should be prefixed with the relevant issue number. Please recreate this PR using required branch name structure (e.g. |
dcorney
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a couple of questions about the tests.
Is this still compatible with genai_checkworthy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the changes look fine. I didn't look in depth at a lot of the code I assume had been brought over from pas.
One thing I will say is that some functions are now asynchronous that formerly weren't. That means in demo scripts they need to be run as asyncio.run. Worth double checking if that will have any knock-on on checkworthy too.
Fixes #1671.
In line with PASTEL in PaS, return all scores for all questions when PASTEL is run, and add a function to recalculate these scores. Also refactored location of some models.
Pull request checklist
main