Skip to content

Conversation

@c-j-johnston
Copy link
Contributor

@c-j-johnston c-j-johnston commented Dec 2, 2025

Fixes #1671.

In line with PASTEL in PaS, return all scores for all questions when PASTEL is run, and add a function to recalculate these scores. Also refactored location of some models.


Pull request checklist

  • I have linked my PR to an issue
  • I’ve used conventional commits
  • My branch is up-to-date with main
  • Where appropriate, I have added or updated tests
  • Where appropriate, I have updated documentation to reflect my changes

@c-j-johnston c-j-johnston marked this pull request as ready for review December 3, 2025 16:28
@github-actions
Copy link

github-actions bot commented Dec 3, 2025

❗ The branch name add-returning-scores-and-recalculating-functions-ai-1671 does not follow the pattern [issue-number]-description-here.

In order to correctly link this PR to an issue, the branch name should be prefixed with the relevant issue number.

Please recreate this PR using required branch name structure (e.g. 42-add-returning-scores-and-recalculating-functions-ai-1671).

Copy link

@dcorney dcorney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple of questions about the tests.
Is this still compatible with genai_checkworthy?

Copy link
Contributor

@dearden dearden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the changes look fine. I didn't look in depth at a lot of the code I assume had been brought over from pas.

One thing I will say is that some functions are now asynchronous that formerly weren't. That means in demo scripts they need to be run as asyncio.run. Worth double checking if that will have any knock-on on checkworthy too.

@c-j-johnston c-j-johnston merged commit f4fd60a into main Dec 8, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants