Open
Conversation
the name in the tag has to match the name in the string data='pmedian'
merrickj
requested changes
Jul 25, 2022
Member
merrickj
left a comment
There was a problem hiding this comment.
For this to work with MOS as currently constructed, if tag is changed to pmedian, then line 77 would have to become pmedian = 'pmedian.dat'. Similarly tag could by changed to xyz and then line 77 would be required to be xyz = 'pmedian.dat'. Note that when the MOSBackend parses the file and subsequently creates the model recipe, it will regenerate this line 77 to whatever input file the user uploads to MOS.
The MOS cvxpy kernel requires the input file object to be an actual input file object, while the Pyomo kernel only requires the filename. This will be reconciled in forthcoming update of Pyomo kernel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the name in the tag has to match the name in the string data='pmedian'