Skip to content

Jonaslu fix random and update readme #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jonaslu wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Jonaslu fix random and update readme #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a853619
Remove non-existant sticky balancer from docs
Mar 15, 2017
724755b
Random balancer uses _.sample which is not defined
Mar 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ var CONFIG = {

// Load balancing pattern
// As of now a few are builtin
// random, roundrobin, sticky
// random, roundrobin
pattern: 'roundrobin'
}
],
Expand Down
3 changes: 2 additions & 1 deletion lib/balancers/random.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@ var _ = require('underscore');

// Random Pattern
function random(backends, req, cb) {
return cb(null, _.sample(backends));
var randomArrayIndex = _.random(1, backends.length) - 1;
return cb(null, backends[randomArrayIndex]);
}


Expand Down
2 changes: 1 addition & 1 deletion test/balancer-error.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ var CONFIG = {

// Load balancing pattern
// As of now a few are builtin
// random, roundrobin, sticky
// random, roundrobin
balancer: function(backends, req, cb) {
// Fail first
cb(new Error('Failed balancing because of whatever'));
Expand Down
2 changes: 1 addition & 1 deletion test/basic.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@ var CONFIG = {

// Load balancing pattern
// As of now a few are builtin
// random, roundrobin, sticky
balancer: loadfire.balancers.roundrobin,
// random, roundrobin

middleware: [
function(req, res, next) {
Expand Down
2 changes: 1 addition & 1 deletion test/middleware.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ var CONFIG = {

// Load balancing pattern
// As of now a few are builtin
// random, roundrobin, sticky
// random, roundrobin
balancer: loadfire.balancers.roundrobin,

middleware: [
Expand Down
2 changes: 1 addition & 1 deletion test/ws.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ var CONFIG = {

// Load balancing pattern
// As of now a few are builtin
// random, roundrobin, sticky
// random, roundrobin
balancer: function(backends, req, cb) {
return cb(null, {
host: 'localhost',
Expand Down