-
Notifications
You must be signed in to change notification settings - Fork 104
adding a test that runs describe command on encrypted backup #2403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Result of fdb-kubernetes-operator-pr on Linux RHEL 9
|
Result of fdb-kubernetes-operator-pr on Linux RHEL 9
|
Result of fdb-kubernetes-operator-pr on Linux RHEL 9
|
johscheuer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.. validates that the restore is happening with the same encryption key.
I think the last bit is wrong right? In the describe check we only check that the backup is encrypted but we don't have any knowledge about the key?
We never updated the key in backup config, so we are using the same key for both encryption and restore. |
Result of fdb-kubernetes-operator-pr on Linux RHEL 9
|
Result of fdb-kubernetes-operator-pr on Linux RHEL 9
|
37c6b64 to
3c967f8
Compare
Result of fdb-kubernetes-operator-pr on Linux RHEL 9
|
Result of fdb-kubernetes-operator-pr on Linux RHEL 9
|
Result of fdb-kubernetes-operator-pr on Linux RHEL 9
|
Result of fdb-kubernetes-operator-pr on Linux RHEL 9
|
Result of fdb-kubernetes-operator-pr on Linux RHEL 9
|
Description
This PR adds a new test case where we run the describe command on an encrypted backup and validates that the restore is happening with the same encryption key.
Type of change
Please select one of the options below.
Discussion
Are there any design details that you would like to discuss further?
No
Testing
Please describe the tests that you ran to verify your changes. Unit tests?
Manual testing?
I ran the e2e test manually:
Do we need to perform additional testing once this is merged, or perform in a larger testing environment?
No
Documentation
Did you update relevant documentation within this repository?
N/A
If this change is adding new functionality, do we need to describe it in our user manual?
N/A
If this change is adding or removing subreconcilers, have we updated the core technical design doc to reflect that?
N/A
If this change is adding new safety checks or new potential failure modes, have we documented and how to debug potential issues?
N/A
Follow-up
Are there any follow-up issues that we should pursue in the future?
N/A
Does this introduce new defaults that we should re-evaluate in the future?
N/A