Skip to content

Conversation

@flaviacris03
Copy link
Member

@flaviacris03 flaviacris03 commented Jan 5, 2026

Description

This PR integrates the newest version of Zalmoxis 26.01.06 into PROTEUS.

General Workflow: Zalmoxis prescribes the initial temperature profile (initial thermal state of the planet). Based on defined constraints (mass, CMF etc.), Zalmoxis solves the interior structure and determines the location of the core-mantle boundary (CMB). The resulting mantle temperature profile is then rescaled and passed to Aragog using its prescribed initial-condition temperature mode. Aragog subsequently takes over and computes the planet’s long-term thermal evolution.

Closes Issue 37 from Zalmoxis.

Validation of changes

  • Ran a grid of simulations for 1-6 EM with all_options.toml with 'zalmoxis' as struct module for default values.

Tests pass on MacOS with Python 3.12.9.

Checklist

  • I have followed the contributing guidelines
  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • My changes generate no new warnings or errors
  • I have checked that the tests still pass on my computer
  • I have updated the docs, as appropriate
  • I have added tests for these changes, as appropriate
  • I have checked that all dependencies have been updated, as required

Relevant people

@timlichtenberg @nichollsh

@timlichtenberg
Copy link
Member

Great, let us know when you want feedback on this.

timlichtenberg
timlichtenberg previously approved these changes Jan 9, 2026
@flaviacris03
Copy link
Member Author

I ran a grid of simulations for 1-6 EM planets using all_options.toml, with zalmoxis as the [struct] module and default parameter values. Since the [orbit] module uses lovepy as default, the simulations run for several 10s of timesteps before crashing with a LovePy error (matrix contains Infs or NaNs). This seems to occur after RF_depth reaches zero.

Running the identical grid with the dummy [orbit] module completes without issues, and all planets fully solidify.

@timlichtenberg I'm not sure whether this behavior is an issue for this PR or should be handled separately, but it needs to be discussed.

@flaviacris03 flaviacris03 marked this pull request as ready for review January 10, 2026 17:00
@flaviacris03 flaviacris03 requested a review from a team as a code owner January 10, 2026 17:00
@timlichtenberg
Copy link
Member

Let's put the orbit module to dummy for the time being for all_options.

@flaviacris03
Copy link
Member Author

@timlichtenberg @FormingWorlds/proteus-maintainer, this PR is now ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants