Fix Java 17 build issues; Update Gradle #1
+67
−64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove unneeded `UNUserNotificationCenter requestAuthorizationWithOptions`
josh-flyclops
approved these changes
Jul 15, 2024
Comment on lines
-17
to
-20
| } else { | ||
| UIUserNotificationSettings* notificationSettings = [UIUserNotificationSettings settingsForTypes:UIUserNotificationTypeAlert | UIUserNotificationTypeBadge | UIUserNotificationTypeSound categories:[[UIApplication sharedApplication] currentUserNotificationSettings].categories]; | ||
| [[UIApplication sharedApplication] registerUserNotificationSettings:notificationSettings]; | ||
| } |
There was a problem hiding this comment.
Are you sure we don't need this?
LegendAF
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a clone of the upstream PR g123k#92 . They updated AGP to a version that is compatible with
platform_client.FYI The upstream repo was marked discontinued July 11 by the owner. They didn't write about any alternative.