Open
Conversation
Contributor
Author
|
@BalaM314 not quite sure what's with all the github actions bots, but they seem pretty broken rn |
Contributor
|
mildly concerned about throwback maps cuz i have slight trauma from seeing maps like frontline be played 5 million times and i do not want those times to come back |
Member
|
i meant you need to update the pnpm-lock.yaml, not the package-lock.json... but you don't have PNPM I should make the actions bot do it also this pr needs rebasing |
BalaM314
force-pushed
the
feat-maps_menu
branch
from
e932947 to
9748247
Compare
BalaM314
requested changes
Jan 12, 2026
BalaM314
force-pushed
the
feat-maps_menu
branch
from
c6d6776 to
975703a
Compare
BalaM314
force-pushed
the
feat-maps_menu
branch
from
c7fd8f1 to
7510eca
Compare
BalaM314
reviewed
Jan 14, 2026
| showVotes(); | ||
| } | ||
|
|
||
| args.map ??= await currentMenu(sender); |
Member
There was a problem hiding this comment.
We have a function that fills in the value of an omitted argument of type map... I think this should be moved into the commands framework
…sh-commands into feat-maps_menu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Features
/nextmapnow includes a no-arg option, which displays a advanced map-selecting GUI (see pictures). GUI additionally features space for future throwback map functionality (Throwback Maps #155) and campaign support (Proper Campaign Support #156)/mapscommand depreciatedImages