-
Notifications
You must be signed in to change notification settings - Fork 538
bump firebase-frameworks version to 0.11.9 #455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @leoortizz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly bumps the version of firebase-frameworks to 0.11.9 in package.json and package-lock.json. This release, as described, is for adding Node.js 24 support, which is reflected in the package's engines configuration. The changes are straightforward and look good.
|
Thanks @leoortizz! Is there anything I can do to make sure npm warn exec The following package was not found and will be installed: firebase-tools@15.0.0
npm warn deprecated node-domexception@1.0.0: Use your platform's native DOMException instead
WARNING: Your package.json contains a custom build that is being ignored. Only the Next.js default build script (e.g, "next build") is respected. If you have a more advanced build process you should build a custom integration https://firebase.google.com/docs/hosting/express
npm error code EBADENGINE
npm error engine Unsupported engine
npm error engine Not compatible with your version of node/npm: firebase-frameworks@0.11.8
npm error notsup Not compatible with your version of node/npm: firebase-frameworks@0.11.8
npm error notsup Required: ***"node":"^16.0.0 || ^18.0.0 || ^20.0.0 || ^22.0.0"***
npm error notsup Actual: ***"npm":"11.6.2","node":"v24.11.1"*** |
It should pick up the latest version when available. Unfortunately, at the moment we're having an issue with our access token used to publish new versions: https://github.com/FirebaseExtended/firebase-framework-tools/actions/runs/20243645859/job/58118158298#step:6:155 It should be fixed soon. As soon as it's available, new deployments will pick up the new version automatically. |
|
Great, thanks again! |
Release Node.js 24 support