Skip to content

Conversation

@leoortizz
Copy link
Contributor

Release Node.js 24 support

@gemini-code-assist
Copy link

Summary of Changes

Hello @leoortizz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the firebase-frameworks package to version "0.11.9". The primary goal of this update is to introduce support for Node.js 24, ensuring that projects utilizing this framework can leverage the latest Node.js runtime features and improvements.

Highlights

  • Version Bump: The firebase-frameworks package has been updated from version "0.11.8" to "0.11.9" across the project's dependency lock file and its own package definition.
  • Node.js 24 Support: This specific version increment is intended to release and incorporate support for Node.js 24, enhancing compatibility for newer environments.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly bumps the version of firebase-frameworks to 0.11.9 in package.json and package-lock.json. This release, as described, is for adding Node.js 24 support, which is reflected in the package's engines configuration. The changes are straightforward and look good.

@leoortizz leoortizz merged commit de280c3 into main Dec 15, 2025
10 checks passed
@leoortizz leoortizz deleted the leoortizz_firebaseFrameworks0119 branch December 15, 2025 18:41
@service-paradis
Copy link
Contributor

Thanks @leoortizz! Is there anything I can do to make sure firebase-tools load the latest version?

npm warn exec The following package was not found and will be installed: firebase-tools@15.0.0
  npm warn deprecated node-domexception@1.0.0: Use your platform's native DOMException instead
  WARNING: Your package.json contains a custom build that is being ignored. Only the Next.js default build script (e.g, "next build") is respected. If you have a more advanced build process you should build a custom integration https://firebase.google.com/docs/hosting/express
  npm error code EBADENGINE
  npm error engine Unsupported engine
  npm error engine Not compatible with your version of node/npm: firebase-frameworks@0.11.8
  npm error notsup Not compatible with your version of node/npm: firebase-frameworks@0.11.8
  npm error notsup Required: ***"node":"^16.0.0 || ^18.0.0 || ^20.0.0 || ^22.0.0"***
  npm error notsup Actual:   ***"npm":"11.6.2","node":"v24.11.1"***

@leoortizz
Copy link
Contributor Author

Thanks @leoortizz! Is there anything I can do to make sure firebase-tools load the latest version?

npm warn exec The following package was not found and will be installed: firebase-tools@15.0.0
  npm warn deprecated node-domexception@1.0.0: Use your platform's native DOMException instead
  WARNING: Your package.json contains a custom build that is being ignored. Only the Next.js default build script (e.g, "next build") is respected. If you have a more advanced build process you should build a custom integration https://firebase.google.com/docs/hosting/express
  npm error code EBADENGINE
  npm error engine Unsupported engine
  npm error engine Not compatible with your version of node/npm: firebase-frameworks@0.11.8
  npm error notsup Not compatible with your version of node/npm: firebase-frameworks@0.11.8
  npm error notsup Required: ***"node":"^16.0.0 || ^18.0.0 || ^20.0.0 || ^22.0.0"***
  npm error notsup Actual:   ***"npm":"11.6.2","node":"v24.11.1"***

It should pick up the latest version when available. Unfortunately, at the moment we're having an issue with our access token used to publish new versions: https://github.com/FirebaseExtended/firebase-framework-tools/actions/runs/20243645859/job/58118158298#step:6:155

It should be fixed soon. As soon as it's available, new deployments will pick up the new version automatically.

@service-paradis
Copy link
Contributor

Great, thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants