fix bug of duplicated dataset namespace#578
Open
liouxiao wants to merge 1 commit intoFederatedAI:main-1.xfrom
Open
fix bug of duplicated dataset namespace#578liouxiao wants to merge 1 commit intoFederatedAI:main-1.xfrom
liouxiao wants to merge 1 commit intoFederatedAI:main-1.xfrom
Conversation
Signed-off-by: liuxiaoxi <liuxiaoxi@sdibc.cn>
67ce3c6 to
ca0d146
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we are using Fate 1.11 with dsl_version = 2, and find the namespaces of different hosts are always same - although we use different name for them.
For example, we have 2 hosts - "host1" (with dataset "ns1"), "host2" (with dataset "ns2"), but the dashboard shows both hosts' datasets as "ns2".
The issue is caused by RuntimeConfParserV2.get_input_parameters() -
FATE-Flow/python/fate_flow/utils/runtime_conf_parse_util.py
Line 518 in 168d9ee
the elements of input_parameters[role] all refer to the same object!
Look at these example:
the output is:
both a[0] and a[1] are actually the same object.
The solution is to replace the assignment with "List Comprehensions", like: